-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Update QuickStart guides to use copy/paste links to lastest version #450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update QuickStart guides to use copy/paste links to lastest version #450
Conversation
… the latest version of code-server with no modification by the user
…ely small to download and if the user has not deleted the old version download then the new version would not overwrite it. Could also be fixed by downloading the file with a version number but would complicate the commands.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we had a shell script in the repo to download the latest release, then just have users curl that and pipe it into bash? I think it would save a lot of documentation duplication. We could also redirect to it from a vanity URL on coder.com to make it look clean.
I'm thinking something like curl https://dl.coder.com | bash
would be really clean.
Also, it would be nice to mention docker in these since they were written before we published to docker, but that's not in the scope of this pr so feel free to defer.
to test the script you can use the following command as I set the link in the guides to point to codercom/code-server/master rather than to my forked repo:
If there's a better place to store the script feel free to store it elsewhere and then update the link to point to that more permanent location. |
cc @nhooyr |
In the future it would be nice for the script to be OS aware (darwin vs linux), but since this is only mentioned from the cloud guides we can work on that later. |
I can easily update the script to automatically find the current running os darwin or linux then download and install the correct file. The rest of the guide would need to be updated as well. Should I do it in this PR or in a new one? |
I've updated to be in-line with master and am not planning on adding anything else to this PR unless anyone else has anything to change. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not have the time atm to make sure this script works correctly.
See #94 We can remove almost all of these docs now. |
Are you recommending closing because sshcode automatically downloads the latest version of code-server? |
Yes. |
Obsoleted by GH-857. |
Describe in detail the problem you had and how this PR fixes it
No problem, just a feature update to follow up on comment submitted in PR 255.
It uses the api to find the latest release version, downloads it, and extracts it over the old version to update code server to the latest version of code-server with no changes to the commands required by the user.
Is there an open issue you can link to?
No